<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102681/">http://git.reviewboard.kde.org/r/102681/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System and Alexander Neundorf.</div>
<div>By Aleix Pol Gonzalez.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have two Phonon installs: Archlinux's in /usr and mine in a home directory.
The problem was that all the modules found the correct Phonon install but KDELibs, because KDE4_LIB_INSTALL_DIR was not yet defined when calling find_package(Phonon ...). This lead to a buggy KDELibs4LibraryTargets-debugfull.cmake file that was pointing to /usr/lib/libphonon.so in some targets, thus making it impossible to compile some applications that depend on it.
This patch delays the Phonon lookup until we have the LIB_INSTALL_DIR variable defined and, in case there isn't a KDE4_KDE4_LIB_INSTALL_DIR variable, it defines one (there can't be if there's no KDELibsDefinitions.cmake file yet, aka a bootstrapping KDELibs4Internal.cmake call).
I'm not sure it's the best approach but it's working here and I think that will be a good help, since I had this problem before and had to workaround it.
Hope this helps.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled both kdelibs and kde-runtime successfully.
(before it complained in kde-runtime/khelpcenter because KDE4__khtml implied the dependency to /usr/libphonon.so).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindKDE4Internal.cmake <span style="color: grey">(ef705fb)</span></li>
<li>cmake/modules/FindPhonon.cmake <span style="color: grey">(cd9e5cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102681/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>