FindMsgfmt

Chusslove Illich caslav.ilic at gmx.net
Sun Sep 18 11:01:36 UTC 2011


> [: Yury G. Kudryashov :]
> Review the attached version of FindMsgfmt, please.
>   [...]
>   +  if(${_tmp} MATCHES "msgfmt \\(GNU gettext-tools\\) ([0-9]+\\.[0-9]+\\.[0-9]+)\n")

I think this is a bit too specific check, and I know for a fact that minor
version number is not always present. I would use a more relaxed regex,
such as

  "msgfmt.* ([0-9]+\\.[0-9]+(\\.[0-9]+)?)"


-- 
Chusslove Illich (Часлав Илић)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20110918/120163ad/attachment.sig>


More information about the Kde-buildsystem mailing list