[PATCH] kdeplasma-addons - only build rss/news plasmoids if rss dataengine is guessed to be available

[Alexander Neundorf]

On Thursday 06 May 2010, Maciej Mrozowski wrote:
> On Wednesday 05 of May 2010 08:10:06 Thiago Macieira wrote:
> > Em Quarta-feira 5. Maio 2010, às 03.11.42, Maciej Mrozowski escreveu:
> > > Ok to commit?
> >
> > I'd say no. A runtime dependency could be installed after the code is
> > built, so your change is technically wrong.
> >
> > Instead of trying to detect kdepimlibs as a proxy to having the engine,
> > just add an option to enable/disable the plasmoids you don't want. That
> > way, you can fine-tune control what gets built and what doesn't.
>
> I agree, however it causes following problems:
> - a bit of CMake variable maintenance burden (many new variables added)
> - it's a bit against how it's handled currently - for instance
> LIBATTICA_FOUND already guards ocs dataengine (which has Attica as build
> dependency) and also guards two opendesktop plasmoids (that don't need
> Attica directly but rely on ocs dataengine)

I think I agree to this one. 

> - disabling certain applets should disable their corresponding
> libs/dataengines (like in case of lancelot or rememberthemilk) - so another
> maintenance burden I think everyone would prefer to avoid

Without looking at the module... maybe the directory structure could/should be 
modified then, so that stuff which belongs together is also located 
together ?
This sounds a lot like splitting up the modules...

> Of  course it's fine to do it clean way (like you suggest) but it brings
> enormous future maintenance cost (and I think unnecessary since kdeplasma-
> addons is relatively small package and usually it's not even split in

That's IMO also a valid point.

Alex