[PATCH] kdeplasma-addons - only build rss/news plasmoids if rss dataengine is guessed to be available

Sune Vuorela debian at pusling.com
Thu May 6 18:05:27 CEST 2010


On Wednesday 05 May 2010 08:10:06 Thiago Macieira wrote:
> Em Quarta-feira 5. Maio 2010, às 03.11.42, Maciej Mrozowski escreveu:
> > Ok to commit?
> 
> I'd say no. A runtime dependency could be installed after the code is
> built, so your change is technically wrong.

I agree. Please no more build time checks for runtime dependencies. We have 
enough to patch away of these already.

Instead of not building it, you can do a warning.

if(NOT KDEPIMLIBS_FOUND)
message(Kdepimlibs not found. if this is the same build environment as 
kdebase/workspace, you will get a nonfunctional foo and bar plasma widget. if 
you are distributor, you can probably ignore this)
endif(NOT KDEPIMLIBS_FOUND)


And if there still is some all around, let's get rid of them.

/Sune


More information about the Kde-buildsystem mailing list