[PATCH] kdeplasma-addons - only build rss/news plasmoids if rss dataengine is guessed to be available
reavertm at gmail.com
Thu May 6 00:14:32 CEST 2010
On Wednesday 05 of May 2010 08:10:06 Thiago Macieira wrote:
> Em Quarta-feira 5. Maio 2010, às 03.11.42, Maciej Mrozowski escreveu:
> > Ok to commit?
> I'd say no. A runtime dependency could be installed after the code is
> built, so your change is technically wrong.
> Instead of trying to detect kdepimlibs as a proxy to having the engine,
> just add an option to enable/disable the plasmoids you don't want. That
> way, you can fine-tune control what gets built and what doesn't.
I agree, however it causes following problems:
- a bit of CMake variable maintenance burden (many new variables added)
- it's a bit against how it's handled currently - for instance LIBATTICA_FOUND
already guards ocs dataengine (which has Attica as build dependency) and also
guards two opendesktop plasmoids (that don't need Attica directly but rely on
- disabling certain applets should disable their corresponding
libs/dataengines (like in case of lancelot or rememberthemilk) - so another
maintenance burden I think everyone would prefer to avoid
Of course it's fine to do it clean way (like you suggest) but it brings
enormous future maintenance cost (and I think unnecessary since kdeplasma-
addons is relatively small package and usually it's not even split in
distributions). It would look like something along the lines of attachment
(it's more complex and even doesn't work yet since some inter-CMake-target
dependencies are not set and should).
That being said my previous patch is lousy but compromise.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 6697 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20100506/29088508/attachment.patch
More information about the Kde-buildsystem