cmake kdelibs bails out if dbusmenu-qt is missing

[Andreas Pakulat]

On 06.07.10 00:10:07, Ingo Klöcker wrote:
> On Monday 05 July 2010, Andreas Pakulat wrote:
> > On 05.07.10 14:03:45, Ingo Klöcker wrote:
> > > On Monday 05 July 2010, Andreas Pakulat wrote:
> > > > On 05.07.10 10:56:16, Ingo Klöcker wrote:
> > > > > Hi,
> > > > > 
> > > > > I'm using CMake 2.6.4. When I tried to cmake kdelibs 4.5 it
> > > > > bailed out with the following error instead of properly
> > > > > reporting the missing package:
> > > > > 
> > > > > CMake Error at
> > > > > cmake/modules/FindPackageHandleStandardArgs.cmake:139
> > > > > 
> > > > > (MESSAGE):
> > > > >   Could not find dbusmenu-qt; available at
> > > > >   http://people.canonical.com/~agateau/dbusmenu/ (missing:
> > > > >   DBUSMENUQT_LIBRARIES DBUSMENUQT_INCLUDE_DIR)
> > > > > 
> > > > > Call Stack (most recent call first):
> > > > >   cmake/modules/FindDBusMenuQt.cmake:34
> > > > > 
> > > > > (find_package_handle_standard_args)
> > > > > 
> > > > >   CMakeLists.txt:112 (find_package)
> > > > 
> > > > Uhm, that is actually a proper report of whats missing. It tells
> > > > you what wasn't found and where you can get it from. The reason
> > > > it stops cmake'ing at that point is because missing to find
> > > > required dependencies is considered a fatal error. See cmake's
> > > > documentation for
> > > > FindPackageHandleStandardArgs.
> > > 
> > > Hmm, okay. Most other required missing dependencies are reported
> > > nicely in the list at the end of the cmake run (which is much
> > > nicer because this way you can install all missing dependencies in
> > > one go).
> > 
> > Yeap, those are not using the REQUIRED keyword for find_package.
> > Seems only dbusmenu-qt and strigi are different, I've changed that
> > for trunk now.
> 
> Excellent! (BTW, for dbusmenu-qt it was already changed in trunk by 
> cgiboudeaux and in 4.5 by mmrozowski.)

Heh, I should've re-read the diff before committing (after svn up). I'm
really too use to git workflow already :)

Andreas

-- 
You could live a better life, if you had a better mind and a better body.