cmake kdelibs bails out if dbusmenu-qt is missing

[Ingo Klöcker]

On Monday 05 July 2010, Andreas Pakulat wrote:
> On 05.07.10 14:03:45, Ingo Klöcker wrote:
> > On Monday 05 July 2010, Andreas Pakulat wrote:
> > > On 05.07.10 10:56:16, Ingo Klöcker wrote:
> > > > Hi,
> > > > 
> > > > I'm using CMake 2.6.4. When I tried to cmake kdelibs 4.5 it
> > > > bailed out with the following error instead of properly
> > > > reporting the missing package:
> > > > 
> > > > CMake Error at
> > > > cmake/modules/FindPackageHandleStandardArgs.cmake:139
> > > > 
> > > > (MESSAGE):
> > > >   Could not find dbusmenu-qt; available at
> > > >   http://people.canonical.com/~agateau/dbusmenu/ (missing:
> > > >   DBUSMENUQT_LIBRARIES DBUSMENUQT_INCLUDE_DIR)
> > > > 
> > > > Call Stack (most recent call first):
> > > >   cmake/modules/FindDBusMenuQt.cmake:34
> > > > 
> > > > (find_package_handle_standard_args)
> > > > 
> > > >   CMakeLists.txt:112 (find_package)
> > > 
> > > Uhm, that is actually a proper report of whats missing. It tells
> > > you what wasn't found and where you can get it from. The reason
> > > it stops cmake'ing at that point is because missing to find
> > > required dependencies is considered a fatal error. See cmake's
> > > documentation for
> > > FindPackageHandleStandardArgs.
> > 
> > Hmm, okay. Most other required missing dependencies are reported
> > nicely in the list at the end of the cmake run (which is much
> > nicer because this way you can install all missing dependencies in
> > one go).
> 
> Yeap, those are not using the REQUIRED keyword for find_package.
> Seems only dbusmenu-qt and strigi are different, I've changed that
> for trunk now.

Excellent! (BTW, for dbusmenu-qt it was already changed in trunk by 
cgiboudeaux and in 4.5 by mmrozowski.)


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20100706/72e9f0a5/attachment.sig