Please review: cmake check for Cagibi

[Alexander Neundorf]

On Tuesday 24 August 2010, Friedrich W. H. Kossebau wrote:
> Mardi, le 24 août 2010, à 20:40, vous avez écrit:
> > On Monday 23 August 2010, Friedrich W. H. Kossebau wrote:
> > The following 4 lines should be good enough:
> >
> > find_program(CAGIBI_DAEMON NAMES cagibid)
> > include(FindPackageHandleStandardArgs)
> > find_package_handle_standard_args(Cagibi  DEFAULT_MSG  CAGIBI_DAEMON)
> > mark_as_advanced(CAGIBI_FOUND CAGIBI_DAEMON)
> >
> >
> > Support for checking the version will come soon to FPHSA(), don't start
> > with FOO_MIN_VERSION now.
> >
> > Maybe you could also rename the file to FindCagibiDaemon.cmake to make
> > very clear what it does, as name for the variable I would suggest
> > CAGIBI_DAEMON_EXECUTABLE.
>
> So okay to commit the attached patch, both to trunk and 4.5 branch?

No, no.

Index: kdebase/runtime/cmake/modules/CMakeLists.txt
===================================================================
--- kdebase/runtime/cmake/modules/CMakeLists.txt	(Revision 1157717)
+++ kdebase/runtime/cmake/modules/CMakeLists.txt	(Arbeitskopie)
@@ -2,6 +2,7 @@
 
 # don't glob for the files, we don't want to install e.g. 
FindLibKNotification-1.cmake
 set(cmakeFiles FindCLucene.cmake
+               FindCagibiDaemon.cmake
                FindSLP.cmake)
 
 set(module_install_dir ${DATA_INSTALL_DIR}/cmake/modules )


Do you *really* want to install that file ?
I think that shouldn't be necessary.

Alex