Please review: cmake check for Cagibi

[Friedrich W. H. Kossebau]

Mardi, le 24 août 2010, à 20:40, vous avez écrit:
> On Monday 23 August 2010, Friedrich W. H. Kossebau wrote:
> The following 4 lines should be good enough:
> 
> find_program(CAGIBI_DAEMON NAMES cagibid)
> include(FindPackageHandleStandardArgs)
> find_package_handle_standard_args(Cagibi  DEFAULT_MSG  CAGIBI_DAEMON)
> mark_as_advanced(CAGIBI_FOUND CAGIBI_DAEMON)
> 
> 
> Support for checking the version will come soon to FPHSA(), don't start
> with FOO_MIN_VERSION now.
> 
> Maybe you could also rename the file to FindCagibiDaemon.cmake to make very
> clear what it does, as name for the variable I would suggest
> CAGIBI_DAEMON_EXECUTABLE.

So okay to commit the attached patch, both to trunk and 4.5 branch?

Cheers
Friedrich
-- 
KDE Okteta - a simple hex editor - http://utils.kde.org/projects/okteta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: addCheckForCagibiDaemon.patch
Type: text/x-patch
Size: 2241 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20100824/32247752/attachment.patch