Please review: cmake check for Cagibi
Friedrich W. H. Kossebau
kossebau at kde.org
Tue Aug 24 21:31:15 CEST 2010
Mardi, le 24 août 2010, à 21:23, vous avez écrit:
> On Tuesday 24 August 2010, Friedrich W. H. Kossebau wrote:
> > Mardi, le 24 août 2010, à 20:40, vous avez écrit:
> > So okay to commit the attached patch, both to trunk and 4.5 branch?
>
> No, no.
>
> Index: kdebase/runtime/cmake/modules/CMakeLists.txt
> ===================================================================
> --- kdebase/runtime/cmake/modules/CMakeLists.txt (Revision 1157717)
> +++ kdebase/runtime/cmake/modules/CMakeLists.txt (Arbeitskopie)
> @@ -2,6 +2,7 @@
>
> # don't glob for the files, we don't want to install e.g.
> FindLibKNotification-1.cmake
> set(cmakeFiles FindCLucene.cmake
> + FindCagibiDaemon.cmake
> FindSLP.cmake)
>
> set(module_install_dir ${DATA_INSTALL_DIR}/cmake/modules )
>
>
> Do you *really* want to install that file ?
> I think that shouldn't be necessary.
Alright. What about this attached version? :)
Friedrich
--
KDE Okteta - a simple hex editor - http://utils.kde.org/projects/okteta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: addCheckForCagibiDaemon.patch
Type: text/x-patch
Size: 1670 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20100824/291b5946/attachment-0001.patch
More information about the Kde-buildsystem
mailing list