[PATCH] Make libresolv optional in kdebase's FindPCIUTILS.cmake

[Thiago Macieira]

Em Quarta-feira 02 Setembro 2009, às 20:06:50, você escreveu:
> 2009/9/2 Thiago Macieira <thiago at kde.org>:
> > Don't add -lresolv.
> >
> > Our apps aren't using it. So we shouldn't have to care if libpciutils is.
> >
> > Then the bug isn't in FreeBSD, but in the Linux distributions. Upstream
> > the issue. We can workaround, but we can't fix it if it's not in our
> > code.
> 
> Do you mean we should revert r842960 and file a bug report to pciutils
> (or the distros)?

Yes.

But we shouldn't break KDE in the process, though. So we can introduce a 
CheckCXXSourceLinks test to ensure it has been fixed. Until it's fixed, the test 
will declare that libpciutils isn't present and therefore disable KDE 
functionality.

(We could use the test to detect whether to link to libresolv, but then we 
don't provide incentive for the distros or pciutils to fix their bugs)

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20090902/9e710e96/attachment.sig