[PATCH] Make libresolv optional in kdebase's FindPCIUTILS.cmake

[Raphael Kubo da Costa]

2009/9/2 Thiago Macieira <thiago at kde.org>:
> Em Quarta-feira 02 Setembro 2009, às 16:23:08, você escreveu:
>> 2009/9/2 Max Brazhnikov <makc at issp.ac.ru>:
>> > On Wed, 02 Sep 2009 08:50:32 +0200, Thiago Macieira wrote:
>> >> Em Quarta-feira 2. Setembro 2009, às 03.42.41, Raphael Kubo da Costa
>> >
>> > escreveu:
>> >> > Hi there,
>> >> >
>> >> > I don't think that piece of code has a proper maintainer, so I think
>> >> > this mailing list is the most appropriate place to send this patch.
>> >> > It's imported from FreeBSD, and makes libresolv optional when
>> >> > detecting pciutils.
>> >> >
>> >> > I don't know the inner workings of pciutils or if KDE needs the
>> >> > functionality provided by libresolv, but the patch itself looks OK.
>> >> >
>> >> > Any objections to committing (I haven't tested it on Linux myself)?
>> >>
>> >> Yes.
>> >>
>> >> Why don't systems build stuff properly? This is either a FreeBSD bug or
>> >> an upstream bug, so please take it there.
>> >
>> > FreeBSD has no separate libresolv, corresponding functions are provided
>> > by libc.
>>
>> So what should be done then?
>
> Don't add -lresolv.
>
> Our apps aren't using it. So we shouldn't have to care if libpciutils is.
>
> Then the bug isn't in FreeBSD, but in the Linux distributions. Upstream the
> issue. We can workaround, but we can't fix it if it's not in our code.

Do you mean we should revert r842960 and file a bug report to pciutils
(or the distros)?