FindQt4 and other CMake module duplication

[Mike Arthur]

2009/7/8 Andreas Pakulat <apaku at gmx.de>:
> That usually happens when there are bugs in the FindXXX modules in cmake,
> in particular in the cmake version we require (current 2.6.2 I think). Or
> if the cmake version we require doesn't ship a suitable FindXXX module we
> need.

> If you are sure that switching to the one coming with the minimum required
> cmake doesn't cause any bugs, then sure.

Ok, I'd be tempted to go down this route. How sure do I need to be? Is
it sufficient to try and remove it and see if I can still do a clean
build on 2.6.2 and 2.6.4 (the most recent)?

> AFAIK, no, because we actually want them to be of higher priority than the
> cmake ones.

Ok, sure, this seems to add to the reasoning to delete them.

>> If not, can these be updated to
>> the latest versions from CMake after each CMake release?
>
> You can merge in relevant changes, sure, they're writeable by anyone.
> However you need to make sure to use only features which are available in
> the minimum required cmake version.

Again, I think this leans towards the approach of deleting our stuff
that's duplicated in the minimum version of CMake we support.

I'll give it a few days before doing this to make sure anyone else
doesn't jump in and tell me why I'm very stupid but otherwise, as long
as I test with 2.6.2/4 does this sound reasonable to do?

-- 
Cheers,
Mike Arthur
http://mikearthur.co.uk/