FindKdepimLibs should require Boost

Andreas Pakulat apaku at gmx.de
Tue Aug 5 10:15:35 CEST 2008


On 05.08.08 00:03:37, Alexander Neundorf wrote:
> On Monday 04 August 2008, Andreas Pakulat wrote:
> > Hi,
> >
> > I hope the subject doesn't stir up a flame-war. I'm not questioning the
> > dependency. My question is: Shouldn't FindKdepimLibs.cmake be requiring
> > Boost? There's currently breakage in the 4.1 branch (kdeplasma-addons)
> > because one part of the comic dataengine in there uses libsyndication
> > from kdepimlibs. However libsyndication contains boost-stuff in its
> > public headers, which means one has to also require boost to build the
> > comic dataengine completely.
> > So shouldn't FindKdepimLibs.cmake have a find_package call for Boost,
> 
> If that's the case, I'd say a clear "yes".
> (I didn't check)
> 
> > probably requiring it. 
> 
> It must only be "REQUIRED", if KdepimLibs has been called with "REQUIRED" 
> itself. Otherwise it must fail non-FATAL.

kdepimlibs does require Boost, but as Pino said its possible to use
quite some parts without boost. So I'm with him that those parts need to
be disabled when Boost isn't found. I'll have a closer look at
FindKdepimLibs.cmake tonight.

Andreas

-- 
Your business will assume vast proportions.


More information about the Kde-buildsystem mailing list