FindKdepimLibs should require Boost
Alexander Neundorf
neundorf at kde.org
Tue Aug 5 00:03:37 CEST 2008
On Monday 04 August 2008, Andreas Pakulat wrote:
> Hi,
>
> I hope the subject doesn't stir up a flame-war. I'm not questioning the
> dependency. My question is: Shouldn't FindKdepimLibs.cmake be requiring
> Boost? There's currently breakage in the 4.1 branch (kdeplasma-addons)
> because one part of the comic dataengine in there uses libsyndication
> from kdepimlibs. However libsyndication contains boost-stuff in its
> public headers, which means one has to also require boost to build the
> comic dataengine completely.
> So shouldn't FindKdepimLibs.cmake have a find_package call for Boost,
If that's the case, I'd say a clear "yes".
(I didn't check)
> probably requiring it.
It must only be "REQUIRED", if KdepimLibs has been called with "REQUIRED"
itself. Otherwise it must fail non-FATAL.
> After all its impossible to use all of kdepimlibs
> without boost. Or we need more logic in FindKdepimLibs.cmake setting
> individual _FOUND variables for the individual libs and setting this to
> no if boost is not found but the specific library contains boost stuff
> in its public headers (like libsyndication).
This also wouldn't hurt. But as you say the part for libsyndication will still
need the check for boost.
Alex
More information about the Kde-buildsystem
mailing list