[Kde-bindings] Kde-bindings Digest, Vol 117, Issue 24

[Dimitar Dobrev]

    Hello,

    This patch looks good, I'm thinking about applying it to the main repository. However, are you sure this change:

-set(KEYFILE \\"${CMAKE_CURRENT_SOURCE_DIR}/key.snk\\")
+set(KEYFILE "${CMAKE_CURRENT_SOURCE_DIR}/key.snk")    

    doesn't break anything? I think the escaped quotes you've removed ensure the path is properly found even if it contains spaces. Of course, if a path with spaces works without these quotes, I'm all for removing them.
    Besides, in quite a few places you've mistyped "SN_EXECUTABLE" - "SN_EXACUTABLE".


    Dimitar   


________________________________
 From: David Lechner <david at lechnology.com>
To: kde-bindings at kde.org 
Sent: Thursday, February 21, 2013 5:25 AM
Subject: Re: [Kde-bindings] Kde-bindings Digest, Vol 117, Issue 24
 
On 1/31/2013 2:08 AM, Cvetoslav Ludmiloff wrote:
> Thanks, I did it the day before, but personally I'm not satisfied with
> that, I need a solution right into cmake files.

In case you haven't done it yourself yet, here is a patch to add signing to the make files.


_______________________________________________
Kde-bindings mailing list
Kde-bindings at kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20130221/bebdb987/attachment-0001.html>