[Kde-bindings] Kde-bindings Digest, Vol 117, Issue 24

[David Lechner]

On 2/21/2013 5:30 AM, Dimitar Dobrev wrote:
>
>      This patch looks good, I'm thinking about applying it to the main
> repository. However, are you sure this change:
>
> -set(KEYFILE \\"${CMAKE_CURRENT_SOURCE_DIR}/key.snk\\")
> +set(KEYFILE "${CMAKE_CURRENT_SOURCE_DIR}/key.snk")
>
>      doesn't break anything? I think the escaped quotes you've removed
> ensure the path is properly found even if it contains spaces. Of course,
> if a path with spaces works without these quotes, I'm all for removing them.

No, I am not sure that it does not break anything. I would need to test 
on windows and have not set this up yet.

>      Besides, in quite a few places you've mistyped "SN_EXECUTABLE" -
> "SN_EXACUTABLE".

That is what I get for staying up way too late at night! :)

I'll work on this some more and post another patch.