<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span><br></span></div><div><span class="tab"> Hello,</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><br><span class="tab"></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"> This patch looks good, I'm thinking about applying it to the main repository. However, are you sure this change:</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><br><span class="tab"></span></div><div style="color: rgb(0, 0, 0); font-size: 16px;
font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab">-set(KEYFILE \\"${CMAKE_CURRENT_SOURCE_DIR}/key.snk\\")<br>+set(KEYFILE "${CMAKE_CURRENT_SOURCE_DIR}/key.snk")</span><span class="tab"> </span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><br><span class="tab"></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"> doesn't break anything? I think the escaped quotes you've removed </span>ensure the path is properly found even if it contains spaces. Of course, if a path with spaces works without these quotes, I'm all for removing them.</div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times
new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"> Besides, in quite a few places you've mistyped "SN_EXECUTABLE" - "SN_EXACUTABLE".<br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"><br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"> Dimitar</span><span class="tab"> </span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><br></div> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times,
serif; font-size: 12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> David Lechner <david@lechnology.com><br> <b><span style="font-weight: bold;">To:</span></b> kde-bindings@kde.org <br> <b><span style="font-weight: bold;">Sent:</span></b> Thursday, February 21, 2013 5:25 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [Kde-bindings] Kde-bindings Digest, Vol 117, Issue 24<br> </font> </div> <br>
On 1/31/2013 2:08 AM, Cvetoslav Ludmiloff wrote:<br>> Thanks, I did it the day before, but personally I'm not satisfied with<br>> that, I need a solution right into cmake files.<br><br>In case you haven't done it yourself yet, here is a patch to add signing to the make files.<br><br><br>_______________________________________________<br>Kde-bindings mailing list<br><a ymailto="mailto:Kde-bindings@kde.org" href="mailto:Kde-bindings@kde.org">Kde-bindings@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/kde-bindings" target="_blank">https://mail.kde.org/mailman/listinfo/kde-bindings</a><br><br><br> </div> </div> </div></body></html>