[k3b] Problems with getting a patch applied

[Chris Smart]

On Sun, May 23, 2010 at 7:02 PM, Jason Bouzane <jabouzane at hotmail.com> wrote:
> The patch should work with 1.91. I'd be interested in the build errors you saw when you tried it. I should mention that the patch was written against the ubuntu k3b source package, which does have some additional patches on top of the vanilla 1.91 release. Maybe that's to blame.

Yeah, I assume so. As I mentioned, I'm not a K3b developer - I just
thought I'd take the time to take a look for you and maybe provide
something helpful.

>
> You might be interested in reading up on the -p parameter for patch. I don't know how k3b normally accepts patches, so I followed a variation on the Linux kernel patching procedure. If you want the patch in another format, I can provide it, but I'd like to see some documentation on the standard format for these things.
> Jason

There's probably some useful information at the KDE Tech Base:
http://techbase.kde.org/Development

I think the format of your patch was just fine (from memory it was in
unified format) and certainly one can patch it with a strip variable
of 2, when applying from multimedia/k3b/ source directory (as checked
out of SVN). Anyway, I was just trying to offer some assistance which
might have helped to get your patch further along. Certainly it is
clear that your patch does not apply cleanly against any version of
the source that I have tried (not that it's insurmountable as the one
file that fails can be manually modified). Nevertheless, I do suggest
that you check out trunk and re-create your patch and make sure that
it builds and runs. Making it harder for devs is not going to help
your cause, but like I said, I'm not a dev and I don't know much.

Good luck!
-c