[k3b] Problems with getting a patch applied

[Jason Bouzane]

----------------------------------------
> Date: Sun, 23 May 2010 11:07:03 +1000
> Subject: Re: [k3b] Problems with getting a patch applied
> From: u3227509 at anu.edu.au
> To: jabouzane at hotmail.com
> CC: k3b at kde.org
>
> On Sun, May 23, 2010 at 3:59 AM, Jason Bouzane  wrote:
>> Hello k3b developers,
>> I've got a patch that fixes bug 182595. The patch is attached to the bug, which I've been pinging for the last month. Unfortunately, it seems it's being ignored, so I was hoping someone could take a look at it and apply the patch.
>
> Hi Jason,
>
> Thanks for your post. I'm not a K3b dev, but I thought I might take a
> look anyway. In the bug report, Sebastian did reply saying that it did
> not crash for him with a build from SVN trunk, which you then do not
> appear to have addressed. Maybe that's why it remains closed..
I did address it. I explained the bugs and I explained why the bugs don't cause a crash, at least until you start to fix them.
> I tried the same with your patch but was unable to get it to _build_
> cleanly against the 1.91.0 tarball, nor against check out of tagged
> 1.91.0 in SVN.
The patch should work with 1.91. I'd be interested in the build errors you saw when you tried it. I should mention that the patch was written against the ubuntu k3b source package, which does have some additional patches on top of the vanilla 1.91 release. Maybe that's to blame.
> Also, your patch does not apply to trunk cleanly due to some code
> changes (one chunk fails). Perhaps you could check out from trunk,
> re-create your patch and update the bug report? I also noticed that
> your patch wants to apply to some strange directory layout, it would
> be nicer if it applied directly to the source code in k3b/src/ rather
> than something like k3b_orig_src/k3b-1.91.0~rc2 - not a major drama as
> it's just one file, but it just makes it easier to apply ;-)

You might be interested in reading up on the -p parameter for patch. I don't know how k3b normally accepts patches, so I followed a variation on the Linux kernel patching procedure. If you want the patch in another format, I can provide it, but I'd like to see some documentation on the standard format for these things.
Jason 		 	   		  
_________________________________________________________________
MSN Dating: Find someone special. Start now.
http://go.microsoft.com/?linkid=9729707