[k3b] confirm (and fix) bug 232148

[Michał Małek]

Sorry for previous message, I have accidently clicked "Send" message

sbalfour at att.net wrote:
> Ok, I have a patch for bug 232148.  Basically, the code for  "Waiting on
> Disk" dialog box just returned on closeEvent without doing anything at
> all, and the cryptic comment in the source that a close will never happen,
> is, well, just plain wrong.  The problem is, action 'Close' in a
> positive-choice dialog box has undefined semantics... we have to make a
> choice. So we ignore the closeEvent and force the user to click on a
> button.  It obviates the crash, and shouldn't have side-effects.  What if
> the user doesn't want to choose?  He has to: he's in the middle of a burn
> operation, and has to go forward or back (Cancel).
Hi Stuart,
You're right, this empty closeEvent() looks fishy.

> 1. what's the testing procedure... is there a scripted regression test?
No such thing unfortunately.

> 2. where do I send the patch?
You can just send it to the mailing list.

> 3. who approves the commit of the patch to the repository?
It's Sebastian Trueg or me.

> 4. where is the repository, and what's the command(s) to commit to it
> (assuming I get that far)?
Repository is here: 
svn://anonsvn.kde.org/home/kde/trunk/extragear/multimedia/k3b (it's read-
only). As Markus already said, you can get commit rights after a couple of 
your patches gets accepted. Before that either Sebastian or me will commit it.
You can find some information about how to start hacking on K3b here: 
http://techbase.kde.org/K3b
Welcome to K3b development!

-- 
Best regards,
Michał