[k3b] confirm (and fix) bug 232148

[Michał Małek]

sbalfour at att.net wrote:
> Folks,
> 
> Ok, I have a patch for bug 232148.  Basically, the code for  "Waiting on
> Disk" dialog box just returned on closeEvent without doing anything at
> all, and the cryptic comment in the source that a close will never happen,
> is, well, just plain wrong.  The problem is, action 'Close' in a
> positive-choice dialog box has undefined semantics... we have to make a
> choice. So we ignore the closeEvent and force the user to click on a
> button.  It obviates the crash, and shouldn't have side-effects.  What if
> the user doesn't want to choose?  He has to: he's in the middle of a burn
> operation, and has to go forward or back (Cancel).
> 
> 1. what's the testing procedure... is there a scripted regression test?
No such thing unfortunately. It would be also not easy to do probably

> 2. where do I send the patch?
> 3. who approves the commit of the patch to the repository?
> 4. where is the repository, and what's the command(s) to commit to it
> (assuming I get that far)?
> 
> Finally, I've subscribed to k3b mailing list, and can send to it, but don't
> receive anything. If a moderator needs to approve my subscription, please
> make it happen.  In the mean time, please CC me on replies.
> 
>                                                        Stuart

-- 
Best regards,
Michał