[k3b] confirm (and fix) bug 232148

Markus kamikazow at web.de
Sun Jun 13 19:53:11 UTC 2010


Am Sonntag 13 Juni 2010, 20:57:22 schrieb sbalfour at att.net:

> 1. what's the testing procedure... is there a scripted regression test?
> 2. where do I send the patch?
> 3. who approves the commit of the patch to the repository?

Usually it's best to upload a diff to http://reviewboard.kde.org/
I always have to fiddle with the Base Directory field, because I can't 
remember it correctly.
I think you have to enter 
trunk/extragear/multimedia/k3b/ (and possibly a sub-dir)

I'm not a programmer, therefore I can't do a proper review, but if the code is 
really as simple as you wrote, it probably doesn't need a full-blown review 
anyway and you can simply mail me the diff or attach it to the bug report and 
I can commit it.


> 4. where is the repository, and what's the command(s) to commit to it
> (assuming I get that far)?

Currently it's svn.kde.org for which you'd need commit rights. If you write a 
few more patches, the KDE Sysadmins grand you an account after request.
If you don't plan to become a somewhat regular (<- I'm using this term very 
loosely here) KDE contributor, the effort to get commit rights is probably not 
worth it (because it takes a few days) and someone of us can simply commit it 
for you.


> Finally, I've subscribed to k3b mailing list, and can send to it, but don't
> receive anything. If a moderator needs to approve my subscription, please
> make it happen.  In the mean time, please CC me on replies.

I got your mails. Other ones were not sent (It's not a busy list ;-) ).
I CC'ed you nonetheless -- just in case.


Markus



More information about the k3b mailing list