Review Request 128625: Only create first/last document hud dialog once

[Nicolas Frattaroli]

> On Aug. 8, 2016, 9:14 a.m., Kai Uwe Broulik wrote:
> > app/mainwindow.h, line 136
> > <https://git.reviewboard.kde.org/r/128625/diff/1/?file=473706#file473706line136>
> >
> >     Put that new member into MainWindow::Private

I'm not really familiar with C++, so how would that be done? Putting a MainWindow::Private in front of the definition does not appear to be the correct way.


> On Aug. 8, 2016, 9:14 a.m., Kai Uwe Broulik wrote:
> > app/mainwindow.cpp, line 1605
> > <https://git.reviewboard.kde.org/r/128625/diff/1/?file=473707#file473707line1605>
> >
> >     You still always need to set the text

What, why? Presumably, if the dialog is already created, the text is already there and it's also already visible.


> On Aug. 8, 2016, 9:14 a.m., Kai Uwe Broulik wrote:
> > app/mainwindow.cpp, line 1604
> > <https://git.reviewboard.kde.org/r/128625/diff/1/?file=473707#file473707line1604>
> >
> >     I don't know the internals and the old code looked the same but doesn't this leak, ie. the dialog is never deleted again?

Maybe, but I don't feel confident enough in my non-existent C++ skills and the gwenview codebase to chase after a possible memory leak that already was there anyway.


- Nicolas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128625/#review98189
-----------------------------------------------------------


On Aug. 7, 2016, 6:33 p.m., Nicolas Frattaroli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128625/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2016, 6:33 p.m.)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Previously, hitting spacebar while the dialog was visible would result in more dialogs being created. With this patch, this will no longer be the case.
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.h 0605aa1 
>   app/mainwindow.cpp aa846cc 
> 
> Diff: https://git.reviewboard.kde.org/r/128625/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas Frattaroli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160808/0b223bc5/attachment.html>