Review Request 126598: Pass JPEG_INCLUDE_DIR to try_run while trying to determine the libjpeg version

Albert Astals Cid aacid at kde.org
Wed Aug 17 21:30:03 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126598/#review98448
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On Jan. 2, 2016, 9:22 a.m., Tobias Berner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126598/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2016, 9:22 a.m.)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> On FreeBSD JPEG_INCLUDE_DIR is correctly set to /usr/local/include, yet it
> is not passed to try_run. Which makes the configure process fail with
> | -- Looking for libjpeg version in /usr/local/include/jpeglib.h
> | CMake Error at lib/CMakeLists.txt:27 (message):
> |  Could not find jpeglib.h.  This file comes with libjpeg.
> 
> This patch passes it via INCLUDE_DIRECTORIES to try_run, fixing the configure.
> 
> 
> Note, this is similar to the abandoned request #125082
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt cd2dbcb 
> 
> Diff: https://git.reviewboard.kde.org/r/126598/diff/
> 
> 
> Testing
> -------
> 
> Build locally.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160817/f86d74c5/attachment.html>


More information about the Gwenview-devel mailing list