Review Request 128625: Only create first/last document hud dialog once

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128625/#review98189
-----------------------------------------------------------



Thanks for your patch!


app/mainwindow.h (line 136)
<https://git.reviewboard.kde.org/r/128625/#comment66143>

    Put that new member into MainWindow::Private



app/mainwindow.cpp (line 1604)
<https://git.reviewboard.kde.org/r/128625/#comment66144>

    I don't know the internals and the old code looked the same but doesn't this leak, ie. the dialog is never deleted again?



app/mainwindow.cpp (line 1605)
<https://git.reviewboard.kde.org/r/128625/#comment66141>

    You still always need to set the text



app/mainwindow.cpp (line 1610)
<https://git.reviewboard.kde.org/r/128625/#comment66142>

    This also needs to be always called, no?


- Kai Uwe Broulik


On Aug. 7, 2016, 4:33 nachm., Nicolas Frattaroli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128625/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2016, 4:33 nachm.)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Previously, hitting spacebar while the dialog was visible would result in more dialogs being created. With this patch, this will no longer be the case.
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.h 0605aa1 
>   app/mainwindow.cpp aa846cc 
> 
> Diff: https://git.reviewboard.kde.org/r/128625/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas Frattaroli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160808/9cd2ab77/attachment.html>