Review Request 123257: Port QtQuickRenderer to Qt5

[Felix Rohrbach]

> On April 9, 2015, 12:30 p.m., Arjen Hiemstra wrote:
> > graphics/glx/glxcontext.cpp, line 151
> > <https://git.reviewboard.kde.org/r/123257/diff/1/?file=360062#file360062line151>
> >
> >     This removes the check for currentWindow, do we really want that?

Well, that was your code ;) Readded it


> On April 9, 2015, 12:30 p.m., Arjen Hiemstra wrote:
> > graphics/glx/glxcontext.cpp, line 206
> > <https://git.reviewboard.kde.org/r/123257/diff/1/?file=360062#file360062line206>
> >
> >     Can we move this to QtQuickRenderer? As it is very QtQuickRenderer specific.

Now it returns the native GLXContext. This, of course, drags glx.h into the header... Renamed it to Context::nativeContext(), too, as Context::context() is a bit confusing.


> On April 9, 2015, 12:30 p.m., Arjen Hiemstra wrote:
> > graphics/glx/glxqtquickrendererprivate.cpp, line 63
> > <https://git.reviewboard.kde.org/r/123257/diff/1/?file=360067#file360067line63>
> >
> >     Can we move some of this functionality into the base class? Most of the actual QML initialisation should be done for all the backends.

Finally found time to do this.


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123257/#review78703
-----------------------------------------------------------


On May 2, 2015, 1:36 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123257/
> -----------------------------------------------------------
> 
> (Updated May 2, 2015, 1:36 p.m.)
> 
> 
> Review request for Gluon and Arjen Hiemstra.
> 
> 
> Repository: gluon
> 
> 
> Description
> -------
> 
> Seems like we finally got something working here :)
> 
> 
> Diffs
> -----
> 
>   graphics/CMakeLists.txt aea38d0 
>   graphics/backend.h 445f4f5 
>   graphics/examples/CMakeLists.txt 9ac8294 
>   graphics/examples/quickrenderer/CMakeLists.txt PRE-CREATION 
>   graphics/examples/quickrenderer/example.qml PRE-CREATION 
>   graphics/examples/quickrenderer/main.cpp PRE-CREATION 
>   graphics/glx/CMakeLists.txt f1d157d 
>   graphics/glx/glxbackend.h 2f799e0 
>   graphics/glx/glxbackend.cpp 09d23ef 
>   graphics/glx/glxcontext.h 5587e59 
>   graphics/glx/glxcontext.cpp e6d9ce5 
>   graphics/glx/glxoutputsurface.cpp 9df09c0 
>   graphics/glx/glxqtquickrenderer.h PRE-CREATION 
>   graphics/glx/glxqtquickrenderer.cpp PRE-CREATION 
>   graphics/glx/glxrendertarget.h d443063 
>   graphics/glx/glxrendertarget.cpp 9f644db 
>   graphics/qtquickrenderer.h a3248c0 
>   graphics/qtquickrenderer.cpp 67afa7b 
>   graphics/rendertarget.cpp 47ee908 
>   graphics/renderwindow.cpp 180f327 
> 
> Diff: https://git.reviewboard.kde.org/r/123257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20150502/ab9515c7/attachment.html>