<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123257/">https://git.reviewboard.kde.org/r/123257/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 9th, 2015, 12:30 p.m. UTC, <b>Arjen Hiemstra</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123257/diff/1/?file=360062#file360062line151" style="color: black; font-weight: bold; text-decoration: underline;">graphics/glx/glxcontext.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Context::destroy()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">146</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="k"><span class="hl">if</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="n"><span class="hl">winId</span></span><span class="hl"> </span><span class="o"><span class="hl">==</span></span> <span class="n">d</span><span class="o">-></span><span class="n">currentWindow</span> <span class="p"><span class="hl">)</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">currentWindow</span> <span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n"><span class="hl">window</span></span><span class="p"><span class="hl">;</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This removes the check for currentWindow, do we really want that?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, that was your code ;) Readded it</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 9th, 2015, 12:30 p.m. UTC, <b>Arjen Hiemstra</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123257/diff/1/?file=360062#file360062line206" style="color: black; font-weight: bold; text-decoration: underline;">graphics/glx/glxcontext.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">204</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QGLXNativeContext</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">context</span><span class="p">,</span> <span class="n">QX11Info</span><span class="o">::</span><span class="n">display</span><span class="p">(),</span> <span class="n">d</span><span class="o">-></span><span class="n">currentWindow</span><span class="o">-></span><span class="n">winId</span><span class="p">()</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can we move this to QtQuickRenderer? As it is very QtQuickRenderer specific.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now it returns the native GLXContext. This, of course, drags glx.h into the header... Renamed it to Context::nativeContext(), too, as Context::context() is a bit confusing.</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 9th, 2015, 12:30 p.m. UTC, <b>Arjen Hiemstra</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123257/diff/1/?file=360067#file360067line63" style="color: black; font-weight: bold; text-decoration: underline;">graphics/glx/glxqtquickrendererprivate.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">GLXQtQuickRendererPrivate</span><span class="o">::</span><span class="n">startQuick</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can we move some of this functionality into the base class? Most of the actual QML initialisation should be done for all the backends.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Finally found time to do this.</p></pre>
<br />
<p>- Felix</p>
<br />
<p>On May 2nd, 2015, 1:36 p.m. UTC, Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Gluon and Arjen Hiemstra.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated May 2, 2015, 1:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gluon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems like we finally got something working here :)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>graphics/CMakeLists.txt <span style="color: grey">(aea38d0)</span></li>
<li>graphics/backend.h <span style="color: grey">(445f4f5)</span></li>
<li>graphics/examples/CMakeLists.txt <span style="color: grey">(9ac8294)</span></li>
<li>graphics/examples/quickrenderer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>graphics/examples/quickrenderer/example.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>graphics/examples/quickrenderer/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>graphics/glx/CMakeLists.txt <span style="color: grey">(f1d157d)</span></li>
<li>graphics/glx/glxbackend.h <span style="color: grey">(2f799e0)</span></li>
<li>graphics/glx/glxbackend.cpp <span style="color: grey">(09d23ef)</span></li>
<li>graphics/glx/glxcontext.h <span style="color: grey">(5587e59)</span></li>
<li>graphics/glx/glxcontext.cpp <span style="color: grey">(e6d9ce5)</span></li>
<li>graphics/glx/glxoutputsurface.cpp <span style="color: grey">(9df09c0)</span></li>
<li>graphics/glx/glxqtquickrenderer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>graphics/glx/glxqtquickrenderer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>graphics/glx/glxrendertarget.h <span style="color: grey">(d443063)</span></li>
<li>graphics/glx/glxrendertarget.cpp <span style="color: grey">(9f644db)</span></li>
<li>graphics/qtquickrenderer.h <span style="color: grey">(a3248c0)</span></li>
<li>graphics/qtquickrenderer.cpp <span style="color: grey">(67afa7b)</span></li>
<li>graphics/rendertarget.cpp <span style="color: grey">(47ee908)</span></li>
<li>graphics/renderwindow.cpp <span style="color: grey">(180f327)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123257/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>