Review Request 123257: Port QtQuickRenderer to Qt5

Arjen Hiemstra ahiemstra at heimr.nl
Thu May 28 12:09:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123257/#review80922
-----------------------------------------------------------

Ship it!


Feel free to push it with the marked line removed.


graphics/CMakeLists.txt (line 8)
<https://git.reviewboard.kde.org/r/123257/#comment55445>

    Isn't Qt5Declarative the old QtQuick 1 module? I doubt we want to drag that in. :)


- Arjen Hiemstra


On May 2, 2015, 1:36 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123257/
> -----------------------------------------------------------
> 
> (Updated May 2, 2015, 1:36 p.m.)
> 
> 
> Review request for Gluon and Arjen Hiemstra.
> 
> 
> Repository: gluon
> 
> 
> Description
> -------
> 
> Seems like we finally got something working here :)
> 
> 
> Diffs
> -----
> 
>   graphics/CMakeLists.txt aea38d0 
>   graphics/backend.h 445f4f5 
>   graphics/examples/CMakeLists.txt 9ac8294 
>   graphics/examples/quickrenderer/CMakeLists.txt PRE-CREATION 
>   graphics/examples/quickrenderer/example.qml PRE-CREATION 
>   graphics/examples/quickrenderer/main.cpp PRE-CREATION 
>   graphics/glx/CMakeLists.txt f1d157d 
>   graphics/glx/glxbackend.h 2f799e0 
>   graphics/glx/glxbackend.cpp 09d23ef 
>   graphics/glx/glxcontext.h 5587e59 
>   graphics/glx/glxcontext.cpp e6d9ce5 
>   graphics/glx/glxoutputsurface.cpp 9df09c0 
>   graphics/glx/glxqtquickrenderer.h PRE-CREATION 
>   graphics/glx/glxqtquickrenderer.cpp PRE-CREATION 
>   graphics/glx/glxrendertarget.h d443063 
>   graphics/glx/glxrendertarget.cpp 9f644db 
>   graphics/qtquickrenderer.h a3248c0 
>   graphics/qtquickrenderer.cpp 67afa7b 
>   graphics/rendertarget.cpp 47ee908 
>   graphics/renderwindow.cpp 180f327 
> 
> Diff: https://git.reviewboard.kde.org/r/123257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20150528/efec2a11/attachment.html>


More information about the Gluon mailing list