Review Request: Proposal how to fix a problem I have with ObjectTreeBuilder

[Felix Rohrbach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103464/
-----------------------------------------------------------

(Updated Jan. 8, 2012, 2:49 p.m.)


Review request for Gluon and Arjen Hiemstra.


Changes
-------

Next try. I'm not sure if the first issue is resolved as you wanted to have it. Fex. you said "Checking whether it is a relative path also needs a better condition than whether or not the parent is set, as they are not mutually exclusive". I thought the reason we introduced that parent was to have a possibility to check whether the reference points into the same gdl file, so if that parent is set to 0, how should I know whether this is the case? 


Description
-------

I added a parameter for the gdl file parent, which is used to create relative paths.


Diffs (updated)
-----

  core/gdl/objecttreebuilder.h 4c51c9b 
  core/gdl/objecttreebuilder.cpp 4dcefa8 
  core/gdlserializer.h e88f179 
  core/gdlserializer.cpp 7b27874 
  engine/assets/other/achievements/achievementsasset.cpp 3c4937b 
  engine/assets/other/statistics/statisticsasset.cpp a78a67e 

Diff: http://git.reviewboard.kde.org/r/103464/diff/diff


Testing
-------

- My problem is solved
- Invaders still loads into creator and can be played.


Thanks,

Felix Rohrbach

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20120108/16678b03/attachment.html>