<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103464/">http://git.reviewboard.kde.org/r/103464/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon and Arjen Hiemstra.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2012, 2:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Next try. I'm not sure if the first issue is resolved as you wanted to have it. Fex. you said "Checking whether it is a relative path also needs a better condition than whether or not the parent is set, as they are not mutually exclusive". I thought the reason we introduced that parent was to have a possibility to check whether the reference points into the same gdl file, so if that parent is set to 0, how should I know whether this is the case? </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I added a parameter for the gdl file parent, which is used to create relative paths.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- My problem is solved
- Invaders still loads into creator and can be played.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/gdl/objecttreebuilder.h <span style="color: grey">(4c51c9b)</span></li>
<li>core/gdl/objecttreebuilder.cpp <span style="color: grey">(4dcefa8)</span></li>
<li>core/gdlserializer.h <span style="color: grey">(e88f179)</span></li>
<li>core/gdlserializer.cpp <span style="color: grey">(7b27874)</span></li>
<li>engine/assets/other/achievements/achievementsasset.cpp <span style="color: grey">(3c4937b)</span></li>
<li>engine/assets/other/statistics/statisticsasset.cpp <span style="color: grey">(a78a67e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103464/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>