Review Request: Add a new prefab instance only once to a prefab

[Dan Leinir Turthra Jensen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102689/#review6779
-----------------------------------------------------------

Ship it!


Looks good, well spotted! :)

- Dan Leinir Turthra


On Sept. 24, 2011, 1:34 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102689/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2011, 1:34 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> As PrefabInstance::setPrefabLink already adds the new instance to the instance list, we don't need to do it again in the Prefab::createInstance function.
> 
> This bug was causing a crash when creating a new prefab from a game object. To reproduce,
> 1. drag a gameobject with at least one child into the prefabs folder
> 2. try to expand the gameobject in the scene model
> 
> 
> Diffs
> -----
> 
>   engine/prefab.cpp ab60e7e 
> 
> Diff: http://git.reviewboard.kde.org/r/102689/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110924/190b28c7/attachment.html>