Review Request: Add a new prefab instance only once to a prefab
Felix Rohrbach
fxrh at gmx.de
Sat Sep 24 13:34:17 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102689/
-----------------------------------------------------------
Review request for Gluon.
Summary
-------
As PrefabInstance::setPrefabLink already adds the new instance to the instance list, we don't need to do it again in the Prefab::createInstance function.
This bug was causing a crash when creating a new prefab from a game object. To reproduce,
1. drag a gameobject with at least one child into the prefabs folder
2. try to expand the gameobject in the scene model
Diffs
-----
engine/prefab.cpp ab60e7e
Diff: http://git.reviewboard.kde.org/r/102689/diff
Testing
-------
Thanks,
Felix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110924/eabbdcbe/attachment.html>
More information about the Gluon
mailing list