Review Request: Achievements 5: AchievementsModel

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102033/#review4947
-----------------------------------------------------------



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4316>

    "gameProject" instead of "p" ?



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4320>

    I think it would make sense to make them translatable.



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4323>

    I would use "No" with capital since that is the beginning of the sentence. You could also use Q_FUNC_INFO or our DEBUG_FUNC_NAME to show a bit more about the class and method if you want. That way it would not be hard coded.



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4322>

    I think it can remain as it is for now since other codes and models look like this way.
    
    I think Felix was trying to keep the consistency here and that is good for now in my opinion.



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4317>

    .at(index.row()) ?



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4319>

    I would personally use switch here, even with just two columns. It can be more extensible. You could also use talkative role names instead of number(s).



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4321>

    You could make them at least translatable, but I would use a green check mark or a red x icon respectively.



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4318>

    .at(section) ?


- Laszlo


On July 21, 2011, 5:13 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102033/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 5:13 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add a first version of a AchievementsModel, which will show the Achievements to the user.
> 
> 
> Diffs
> -----
> 
>   engine/achievement.cpp 13e4f14 
>   player/lib/CMakeLists.txt 24c9164 
>   player/lib/models/achievementsmodel.h PRE-CREATION 
>   player/lib/models/achievementsmodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102033/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110721/06486d5e/attachment-0001.htm