Review Request: Achievements 5: AchievementsModel

[Dan Leinir Turthra Jensen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102033/#review4939
-----------------------------------------------------------



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102033/#comment4307>

    Through the code, we've been using Q_UNUSED in stead of this more old-fashioned way of marking variables.


Other than that, please remember to use ModelChecker on this (it's in the codebase already, you just have to #include "ModelChecker.h" and it'll be there). See e.g. ComponentsModel for some help on how it's used (in short, it's magical, and breaks with information on why when your model does something wrong).

- Dan Leinir Turthra


On July 21, 2011, 5:13 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102033/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 5:13 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add a first version of a AchievementsModel, which will show the Achievements to the user.
> 
> 
> Diffs
> -----
> 
>   engine/achievement.cpp 13e4f14 
>   player/lib/CMakeLists.txt 24c9164 
>   player/lib/models/achievementsmodel.h PRE-CREATION 
>   player/lib/models/achievementsmodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102033/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110721/16b015d5/attachment-0001.htm