Review Request: Achievements 5: AchievementsModel

[Laszlo Papp]

> On July 21, 2011, 8:22 p.m., Laszlo Papp wrote:
> > player/lib/models/achievementsmodel.cpp, lines 44-47
> > <http://git.reviewboard.kde.org/r/102033/diff/2/?file=27791#file27791line44>
> >
> >     "gameProject" instead of "p" ?

Interesting, one of my comments has been left out.

After taking a look at this:
http://fxrh.files.wordpress.com/2011/06/achievement_1.png

I think it is a bit strange to use question mark for "Achieved". You can just leave it out in my opinion since it is implied in this context.


> On July 21, 2011, 8:22 p.m., Laszlo Papp wrote:
> > player/lib/models/achievementsmodel.cpp, line 77
> > <http://git.reviewboard.kde.org/r/102033/diff/2/?file=27791#file27791line77>
> >
> >     You could make them at least translatable, but I would use a green check mark or a red x icon respectively.

But you can also use more roles if you want to keep it this way as well (maybe as a fallback text option?). I just like the visualization here. :p


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102033/#review4947
-----------------------------------------------------------


On July 21, 2011, 5:13 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102033/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 5:13 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add a first version of a AchievementsModel, which will show the Achievements to the user.
> 
> 
> Diffs
> -----
> 
>   engine/achievement.cpp 13e4f14 
>   player/lib/CMakeLists.txt 24c9164 
>   player/lib/models/achievementsmodel.h PRE-CREATION 
>   player/lib/models/achievementsmodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102033/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110721/94e8cbce/attachment.htm