Review Request: Statistics and Achievements, part 2

[Felix Rohrbach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101887/
-----------------------------------------------------------

Review request for Gluon.


Summary
-------

This is the second part of my SoK project, bringing statistics and achievements to gluon. While the first part included mainly the statistics and the databases to save them, this part includes the achievements and a way to show them in gluon player applications (atm there's only an implementation for the KDE Extended player), but also brings improvements to the statistics. It's a bit long, but Arjen Hiemstra said this would be the best way. And don't forget the second page of the diff ;)


Diffs
-----

  creator/plugins/docks/propertiesdock/CMakeLists.txt 05c5242 
  creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.h PRE-CREATION 
  creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp PRE-CREATION 
  creator/x-gluon-mimetypes.xml 378876d 
  engine/CMakeLists.txt e8764f5 
  engine/abstractstatistic.h 494032f 
  engine/achievement.h PRE-CREATION 
  engine/achievement.cpp PRE-CREATION 
  engine/achievementsmanager.h PRE-CREATION 
  engine/achievementsmanager.cpp PRE-CREATION 
  engine/assets/CMakeLists.txt b8c087b 
  engine/assets/other/achievements/CMakeLists.txt PRE-CREATION 
  engine/assets/other/achievements/achievementsasset.h PRE-CREATION 
  engine/assets/other/achievements/achievementsasset.cpp PRE-CREATION 
  engine/assets/other/statistics/statisticsasset.h a1d1995 
  engine/assets/other/statistics/statisticsasset.cpp a8d6372 
  engine/booleanstatistic.h PRE-CREATION 
  engine/booleanstatistic.cpp PRE-CREATION 
  engine/game.cpp d5fc279 
  engine/gameproject.h 805d193 
  engine/gameproject.cpp 8d84024 
  engine/gameprojectprivate.h 38c442a 
  engine/gameprojectprivate.cpp 08424b1 
  engine/gluon_engine_export.h 17fc00c 
  engine/multiscorestatistic.h PRE-CREATION 
  engine/multiscorestatistic.cpp PRE-CREATION 
  engine/projectmetadata.h PRE-CREATION 
  engine/projectmetadata.cpp PRE-CREATION 
  engine/statistic.h e29b2fe 
  engine/tasksstatistic.h PRE-CREATION 
  engine/tasksstatistic.cpp PRE-CREATION 
  player/examples/apocalypse.gluon/game.gluonmeta PRE-CREATION 
  player/examples/ball.gluon/game.gluonmeta PRE-CREATION 
  player/examples/invaders.gluon/game.gluonmeta PRE-CREATION 
  player/examples/jumpnbump.gluon/game.gluonmeta PRE-CREATION 
  player/examples/pong.gluon/game.gluonmeta PRE-CREATION 
  player/kdeext/CMakeLists.txt 40da561 
  player/kdeext/delegates/achievementdelegate.h PRE-CREATION 
  player/kdeext/delegates/achievementdelegate.cpp PRE-CREATION 
  player/kdeext/gamedetailsoverlay.h 99923a2 
  player/kdeext/gamedetailsoverlay.cpp b6f525c 
  player/kdeext/gamesoverlay.cpp d468186 
  player/lib/CMakeLists.txt 5957748 
  player/lib/models/achievementsmodel.h PRE-CREATION 
  player/lib/models/achievementsmodel.cpp PRE-CREATION 
  player/lib/models/commentsmodel.cpp 5a0bff0 
  player/lib/models/gameitemsmodel.h c907f7b 
  player/lib/models/gameitemsmodel.cpp 82f7202 
  player/lib/models/gameviewitem.h 6a7f4ca 
  player/lib/models/gameviewitem.cpp 67f0566 

Diff: http://git.reviewboard.kde.org/r/101887/diff


Testing
-------

It compiles and I tried to test every feature I implemented, but I didn't always tried every combination, so there might be still some bugs.


Thanks,

Felix

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110708/96399bf8/attachment.htm