<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101887/">http://git.reviewboard.kde.org/r/101887/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Felix Rohrbach.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the second part of my SoK project, bringing statistics and achievements to gluon. While the first part included mainly the statistics and the databases to save them, this part includes the achievements and a way to show them in gluon player applications (atm there's only an implementation for the KDE Extended player), but also brings improvements to the statistics. It's a bit long, but Arjen Hiemstra said this would be the best way. And don't forget the second page of the diff ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles and I tried to test every feature I implemented, but I didn't always tried every combination, so there might be still some bugs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>creator/plugins/docks/propertiesdock/CMakeLists.txt <span style="color: grey">(05c5242)</span></li>
<li>creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>creator/x-gluon-mimetypes.xml <span style="color: grey">(378876d)</span></li>
<li>engine/CMakeLists.txt <span style="color: grey">(e8764f5)</span></li>
<li>engine/abstractstatistic.h <span style="color: grey">(494032f)</span></li>
<li>engine/achievement.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/achievement.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/achievementsmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/achievementsmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/assets/CMakeLists.txt <span style="color: grey">(b8c087b)</span></li>
<li>engine/assets/other/achievements/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/assets/other/achievements/achievementsasset.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/assets/other/achievements/achievementsasset.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/assets/other/statistics/statisticsasset.h <span style="color: grey">(a1d1995)</span></li>
<li>engine/assets/other/statistics/statisticsasset.cpp <span style="color: grey">(a8d6372)</span></li>
<li>engine/booleanstatistic.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/booleanstatistic.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/game.cpp <span style="color: grey">(d5fc279)</span></li>
<li>engine/gameproject.h <span style="color: grey">(805d193)</span></li>
<li>engine/gameproject.cpp <span style="color: grey">(8d84024)</span></li>
<li>engine/gameprojectprivate.h <span style="color: grey">(38c442a)</span></li>
<li>engine/gameprojectprivate.cpp <span style="color: grey">(08424b1)</span></li>
<li>engine/gluon_engine_export.h <span style="color: grey">(17fc00c)</span></li>
<li>engine/multiscorestatistic.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/multiscorestatistic.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/projectmetadata.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/projectmetadata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/statistic.h <span style="color: grey">(e29b2fe)</span></li>
<li>engine/tasksstatistic.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/tasksstatistic.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/examples/apocalypse.gluon/game.gluonmeta <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/examples/ball.gluon/game.gluonmeta <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/examples/invaders.gluon/game.gluonmeta <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/examples/jumpnbump.gluon/game.gluonmeta <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/examples/pong.gluon/game.gluonmeta <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/kdeext/CMakeLists.txt <span style="color: grey">(40da561)</span></li>
<li>player/kdeext/delegates/achievementdelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/kdeext/delegates/achievementdelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/kdeext/gamedetailsoverlay.h <span style="color: grey">(99923a2)</span></li>
<li>player/kdeext/gamedetailsoverlay.cpp <span style="color: grey">(b6f525c)</span></li>
<li>player/kdeext/gamesoverlay.cpp <span style="color: grey">(d468186)</span></li>
<li>player/lib/CMakeLists.txt <span style="color: grey">(5957748)</span></li>
<li>player/lib/models/achievementsmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/lib/models/achievementsmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>player/lib/models/commentsmodel.cpp <span style="color: grey">(5a0bff0)</span></li>
<li>player/lib/models/gameitemsmodel.h <span style="color: grey">(c907f7b)</span></li>
<li>player/lib/models/gameitemsmodel.cpp <span style="color: grey">(82f7202)</span></li>
<li>player/lib/models/gameviewitem.h <span style="color: grey">(6a7f4ca)</span></li>
<li>player/lib/models/gameviewitem.cpp <span style="color: grey">(67f0566)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101887/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>