Review Request: Add Category and NewGame classes

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101816/#review4443
-----------------------------------------------------------



player/lib/addgamejob.h
<http://git.reviewboard.kde.org/r/101816/#comment3756>

    addGameFinished (or something like addGameSucceeded) ? 



player/lib/addgamejob.h
<http://git.reviewboard.kde.org/r/101816/#comment3755>

    addGameFailed ?



player/lib/addgamejob.h
<http://git.reviewboard.kde.org/r/101816/#comment3753>

    You are not using the discuss Q_PRIVATE_SLOTS. It might make sense for having a better transition before we make the *_p.h way.



player/lib/addgamejob.cpp
<http://git.reviewboard.kde.org/r/101816/#comment3757>

    Probably nicer to initialize it like Private() : provider(0) {}



player/lib/addgamejob.cpp
<http://git.reviewboard.kde.org/r/101816/#comment3758>

    Match these names with the chosen after all.



player/lib/categorylistjob.h
<http://git.reviewboard.kde.org/r/101816/#comment3759>

    if you use categoryName, maybe categoryId ?



player/lib/categorylistjob.h
<http://git.reviewboard.kde.org/r/101816/#comment3763>

    categoryListFetchFailed and categoryListFetch{Succeeded/Finished} ?



player/lib/categorylistjob.h
<http://git.reviewboard.kde.org/r/101816/#comment3760>

    same, it is easy to make it Q_PRIVATE_SLOT, but if you feel it an issue, just let it that way and I (or someone else) will fix it



player/lib/categorylistjob.cpp
<http://git.reviewboard.kde.org/r/101816/#comment3761>

    maybe category id then for being consistent ?



player/lib/categorylistjob.cpp
<http://git.reviewboard.kde.org/r/101816/#comment3766>

    categoryId ?



player/lib/categorylistjob.cpp
<http://git.reviewboard.kde.org/r/101816/#comment3765>

    same comment as above: Private() : provider(0) {}



player/lib/categorylistjob.cpp
<http://git.reviewboard.kde.org/r/101816/#comment3764>

    Match them with the chosen term.


- Laszlo


On July 4, 2011, 3:19 p.m., Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101816/
> -----------------------------------------------------------
> 
> (Updated July 4, 2011, 3:19 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Category's job is to fetch list of categories from the server.
> NewGame takes a game name and a category, and then creates a new game on the server, returning the ID of newly created game.
> 
> 
> Diffs
> -----
> 
>   player/lib/CMakeLists.txt 53c0f0a 
>   player/lib/addgamejob.h PRE-CREATION 
>   player/lib/addgamejob.cpp PRE-CREATION 
>   player/lib/categorylistjob.h PRE-CREATION 
>   player/lib/categorylistjob.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101816/diff
> 
> 
> Testing
> -------
> 
> Both classes function as expected when used.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110706/8a170d09/attachment-0001.htm