Review Request: Add Category and NewGame classes

[Dan Leinir Turthra Jensen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101816/#review4438
-----------------------------------------------------------

Ship it!


It looks good to me - i was going to comment on the signal names, and suggest that in particular the failed signal might simply be failed(), but this works just fine too :)

- Dan Leinir Turthra


On July 4, 2011, 3:19 p.m., Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101816/
> -----------------------------------------------------------
> 
> (Updated July 4, 2011, 3:19 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Category's job is to fetch list of categories from the server.
> NewGame takes a game name and a category, and then creates a new game on the server, returning the ID of newly created game.
> 
> 
> Diffs
> -----
> 
>   player/lib/CMakeLists.txt 53c0f0a 
>   player/lib/addgamejob.h PRE-CREATION 
>   player/lib/addgamejob.cpp PRE-CREATION 
>   player/lib/categorylistjob.h PRE-CREATION 
>   player/lib/categorylistjob.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101816/diff
> 
> 
> Testing
> -------
> 
> Both classes function as expected when used.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110706/90326047/attachment.htm