Review Request: Add Category and NewGame classes

Shantanu Tushar Jha jhahoneyk at gmail.com
Wed Jul 6 12:56:37 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101816/
-----------------------------------------------------------

(Updated July 6, 2011, 10:56 a.m.)


Review request for Gluon.


Changes
-------

Changed signal names, made variable names consistent. Q_PRIVATE_SLOT not done yet, as discussed.


Summary
-------

Category's job is to fetch list of categories from the server.
NewGame takes a game name and a category, and then creates a new game on the server, returning the ID of newly created game.


Diffs (updated)
-----

  player/lib/CMakeLists.txt 53c0f0a 
  player/lib/addgamejob.h PRE-CREATION 
  player/lib/addgamejob.cpp PRE-CREATION 
  player/lib/categorylistjob.h PRE-CREATION 
  player/lib/categorylistjob.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101816/diff


Testing
-------

Both classes function as expected when used.


Thanks,

Shantanu Tushar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110706/95516018/attachment.htm 


More information about the Gluon mailing list