Review Request: Fix two errors in {Statistics,Achievements}Asset

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103452/#review9274
-----------------------------------------------------------


This review has been submitted with commit 68ba0bee507fec2974b43774fb857dd5d7a548fc by Felix Rohrbach to branch master.

- Commit Hook


On Dec. 18, 2011, 4:57 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103452/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 4:57 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> 1. The deletion of Achievements/Statistics when calling unload makes the creator crash. Solution: Don't unload. Most assets don't do that either.
>  
> 2. The automatic loading caused an endless recursion, as the gdl parser checks whether the object already exists in the object tree, which causes load() to be called again. Solution: mark as loaded earlier.
> 
> 
> Diffs
> -----
> 
>   engine/assets/other/achievements/achievementsasset.cpp b84c3e0 
>   engine/assets/other/statistics/statisticsasset.cpp 1edc7c4 
> 
> Diff: http://git.reviewboard.kde.org/r/103452/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111226/5fdfc8bb/attachment.html>