<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103452/">http://git.reviewboard.kde.org/r/103452/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 68ba0bee507fec2974b43774fb857dd5d7a548fc by Felix Rohrbach to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 18th, 2011, 4:57 p.m., Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2011, 4:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. The deletion of Achievements/Statistics when calling unload makes the creator crash. Solution: Don't unload. Most assets don't do that either.
2. The automatic loading caused an endless recursion, as the gdl parser checks whether the object already exists in the object tree, which causes load() to be called again. Solution: mark as loaded earlier.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>engine/assets/other/achievements/achievementsasset.cpp <span style="color: grey">(b84c3e0)</span></li>
<li>engine/assets/other/statistics/statisticsasset.cpp <span style="color: grey">(1edc7c4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103452/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>