Review Request: Fix two errors in {Statistics,Achievements}Asset

Felix Rohrbach fxrh at gmx.de
Sun Dec 18 16:57:59 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103452/
-----------------------------------------------------------

Review request for Gluon.


Description
-------

1. The deletion of Achievements/Statistics when calling unload makes the creator crash. Solution: Don't unload. Most assets don't do that either.
 
2. The automatic loading caused an endless recursion, as the gdl parser checks whether the object already exists in the object tree, which causes load() to be called again. Solution: mark as loaded earlier.


Diffs
-----

  engine/assets/other/achievements/achievementsasset.cpp b84c3e0 
  engine/assets/other/statistics/statisticsasset.cpp 1edc7c4 

Diff: http://git.reviewboard.kde.org/r/103452/diff/diff


Testing
-------


Thanks,

Felix Rohrbach

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111218/0ea469dd/attachment.html>


More information about the Gluon mailing list