Review Request: Use load/unload in the {Statistic, Achievement}Asset

Commit Hook null at kde.org
Thu Dec 8 18:37:08 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103341/#review8806
-----------------------------------------------------------


This review has been submitted with commit 4475891bac916bb385308b5e9e987ca868a95bad by Felix Rohrbach to branch master.

- Commit Hook


On Dec. 5, 2011, 10:28 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103341/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2011, 10:28 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> Additionally, call GDLSerializer::read with gameProject() as third parameter. This should fix achievements with the new gdl parser :)
> 
> 
> Diffs
> -----
> 
>   engine/assets/other/achievements/achievementsasset.h a7943cb 
>   engine/assets/other/achievements/achievementsasset.cpp 4813df8 
>   engine/assets/other/statistics/statisticsasset.h f7f2684 
>   engine/assets/other/statistics/statisticsasset.cpp c1d90fe 
> 
> Diff: http://git.reviewboard.kde.org/r/103341/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111208/e4e769f6/attachment.html>


More information about the Gluon mailing list