Review Request: Achievements 10: icons, score

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102476/#review6190
-----------------------------------------------------------



engine/achievement.h
<http://git.reviewboard.kde.org/r/102476/#comment5443>

    Please, please, please do not use TextureAsset here. I know it is being done in GameProject but it is absolutely not the way to use texture assets. Since TextureAsset is a plugin, this means that GluonEngine now needs to link to one of its plugins for this to work... which is really nasty.
    
    Instead, you should simply use Asset here and ignore any asset that does not provide the correct data in the setter. Eventually, this information will be provided by the Asset class so that we can filter properly. But until then, please just use Asset.


- Arjen


On Aug. 28, 2011, 1:37 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102476/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2011, 1:37 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Achievements now have icons, AchievementsManager saves the current Score
> 
> 
> Diffs
> -----
> 
>   engine/achievementsmanager.cpp a657074 
>   engine/achievementsmanager.h d2c35a3 
>   engine/achievement.h 84018de 
>   engine/achievement.cpp 75cef86 
>   player/lib/models/achievementsmodel.cpp cb5db2f 
> 
> Diff: http://git.reviewboard.kde.org/r/102476/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110831/95996f8c/attachment.html>