Review Request: Achievements 10: icons, score

Laszlo Papp lpapp at kde.org
Sun Aug 28 17:44:49 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102476/#review6101
-----------------------------------------------------------



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102476/#comment5390>

    I can also do this in my commit, if you would like to ignore it in this step. It is not a big deal either way for me.


- Laszlo


On Aug. 28, 2011, 1:37 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102476/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2011, 1:37 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Achievements now have icons, AchievementsManager saves the current Score
> 
> 
> Diffs
> -----
> 
>   engine/achievementsmanager.cpp a657074 
>   engine/achievementsmanager.h d2c35a3 
>   engine/achievement.h 84018de 
>   engine/achievement.cpp 75cef86 
>   player/lib/models/achievementsmodel.cpp cb5db2f 
> 
> Diff: http://git.reviewboard.kde.org/r/102476/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110828/f7e0fc74/attachment.html>


More information about the Gluon mailing list