<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102476/">http://git.reviewboard.kde.org/r/102476/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102476/diff/2/?file=33196#file33196line55" style="color: black; font-weight: bold; text-decoration: underline;">engine/achievement.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace GluonEngine</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span class="p">(</span> <span class="n">GluonEngine</span><span class="o">::</span><span class="n">TextureAsset</span><span class="o">*</span> <span class="n">icon</span> <span class="n">READ</span> <span class="n">icon</span> <span class="n">WRITE</span> <span class="n">setIcon</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please, please, please do not use TextureAsset here. I know it is being done in GameProject but it is absolutely not the way to use texture assets. Since TextureAsset is a plugin, this means that GluonEngine now needs to link to one of its plugins for this to work... which is really nasty.
Instead, you should simply use Asset here and ignore any asset that does not provide the correct data in the setter. Eventually, this information will be provided by the Asset class so that we can filter properly. But until then, please just use Asset.</pre>
</div>
<br />
<p>- Arjen</p>
<br />
<p>On August 28th, 2011, 1:37 p.m., Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2011, 1:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Achievements now have icons, AchievementsManager saves the current Score</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>engine/achievementsmanager.cpp <span style="color: grey">(a657074)</span></li>
<li>engine/achievementsmanager.h <span style="color: grey">(d2c35a3)</span></li>
<li>engine/achievement.h <span style="color: grey">(84018de)</span></li>
<li>engine/achievement.cpp <span style="color: grey">(75cef86)</span></li>
<li>player/lib/models/achievementsmodel.cpp <span style="color: grey">(cb5db2f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102476/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>