Review Request: Achievements 8: Make use of the AchievementsManager and the ProjectMetaData classes.

[Felix Rohrbach]

> On Aug. 16, 2011, 3:29 p.m., Laszlo Papp wrote:
> > Mmm, I stopped marking the game* -> project* renaming after a while (it is no a bit mixed), so I might have missed something. If you would not like to do that renaming in this patch, that is fine. I can also do it later. That is not a biggie.

I won't include the name changes in gameviewitem (game->project and some more), as I don't think they belong in this patch. I don't think it's a good idea to change api somewhere hidden in a patch about something completely different. So I'd vote for doing these changes in another commit.


> On Aug. 16, 2011, 3:29 p.m., Laszlo Papp wrote:
> > player/lib/models/gameviewitem.cpp, line 87
> > <http://git.reviewboard.kde.org/r/102245/diff/3/?file=31242#file31242line87>
> >
> >     Why not just projectDir term ? projectDirName reminds me that it is just the *.gluon bundle name, and not the path.

$ git blame -L66 player/lib/models/gameviewitem.h:
2813c421 (Laszlo Papp    2011-03-27 17:05:28 +0300 66)             QString projectDirName() const;
;)


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102245/#review5485
-----------------------------------------------------------


On Aug. 9, 2011, 9:02 a.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102245/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2011, 9:02 a.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Now, the user should be able to create games with simple statistics/achievements.
> 
> 
> Diffs
> -----
> 
>   player/lib/models/commentsmodel.cpp 4572f23 
>   player/lib/models/gameitemsmodel.h d2e3604 
>   player/lib/models/gameitemsmodel.cpp c4c977c 
>   player/lib/models/gameviewitem.h a017862 
>   engine/gameproject.cpp 1fc2eb4 
>   player/kdeext/gamedetailsoverlay.h 99923a2 
>   player/kdeext/gamedetailsoverlay.cpp b6f525c 
>   player/kdeext/gamesoverlay.cpp d468186 
>   player/lib/models/achievementsmodel.h 3df946e 
>   player/lib/models/achievementsmodel.cpp e1ebad0 
>   engine/game.cpp 9495909 
>   player/lib/models/gameviewitem.cpp 64dd46a 
> 
> Diff: http://git.reviewboard.kde.org/r/102245/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110827/2aa912f0/attachment.html>