Review Request: Achievements 8: Make use of the AchievementsManager and the ProjectMetaData classes.

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102245/#review5485
-----------------------------------------------------------


Mmm, I stopped marking the game* -> project* renaming after a while (it is no a bit mixed), so I might have missed something. If you would not like to do that renaming in this patch, that is fine. I can also do it later. That is not a biggie. 


engine/game.cpp
<http://git.reviewboard.kde.org/r/102245/#comment4920>

    Capital letter :)



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102245/#comment4922>

    I guess you do not need it. :p



engine/game.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5090>

    // Save ...



engine/gameproject.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5091>

    // Save ... -> I like how you do few lines below, just consistency. :)



player/lib/models/achievementsmodel.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5101>

    As we agreed about it on IRC (just for book-keeping here):
    
    Seems to be a bit outdated. I see only "assets", "scenes" (no capital letter). I would prefer to hide the cache folder in order to make it more clean for a game developer, including myself. It is fine in case of cmake since that works in a shadow build directory, but directly in the project root, it is controversial to me.
    
    Clean project root is a nice thing I would not like to lose in this case, so I would go for solutions like this:
    XDG_CACHE_HOME which defaults to ~/.cache, also ~/.kde4 and so forth.



player/lib/models/commentsmodel.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5105>

    projectId



player/lib/models/commentsmodel.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5106>

    projectId



player/lib/models/commentsmodel.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5107>

    projectId



player/lib/models/gameviewitem.h
<http://git.reviewboard.kde.org/r/102245/#comment5099>

    projectName and projectDescription as proposed below and as it is in your 9th patch.



player/lib/models/gameviewitem.h
<http://git.reviewboard.kde.org/r/102245/#comment5100>

    projectID ?



player/lib/models/gameviewitem.h
<http://git.reviewboard.kde.org/r/102245/#comment5104>

    projectName and projectDescription



player/lib/models/gameviewitem.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5102>

    projectFilePath



player/lib/models/gameviewitem.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5103>

    "...setProjectFilePath(projectFilePath)..."



player/lib/models/gameviewitem.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5098>

    projectName and projectDescription as proposed below and as it is in your 9th patch.



player/lib/models/gameviewitem.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5097>

    projectName and projectDescription as proposed below and as it is in your 9th patch.



player/lib/models/gameviewitem.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5096>

    I think it is a good idea in general to eliminate the game* prefixes we started, and just use project* (ie.: projectName/Description) in this special case. 
    
    Every project is a game project built upon the gluon engine and creator played in the player applications (only the graphics, audio, input library examples are not). :)



player/lib/models/gameviewitem.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5095>

    Why not just projectDir term ? projectDirName reminds me that it is just the *.gluon bundle name, and not the path.



player/lib/models/gameviewitem.cpp
<http://git.reviewboard.kde.org/r/102245/#comment5094>

    After the recommandation of the 9th patch, how about calling it projectFilePath ?


- Laszlo


On Aug. 9, 2011, 9:02 a.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102245/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2011, 9:02 a.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Now, the user should be able to create games with simple statistics/achievements.
> 
> 
> Diffs
> -----
> 
>   player/lib/models/commentsmodel.cpp 4572f23 
>   player/lib/models/gameitemsmodel.h d2e3604 
>   player/lib/models/gameitemsmodel.cpp c4c977c 
>   player/lib/models/gameviewitem.h a017862 
>   engine/gameproject.cpp 1fc2eb4 
>   player/kdeext/gamedetailsoverlay.h 99923a2 
>   player/kdeext/gamedetailsoverlay.cpp b6f525c 
>   player/kdeext/gamesoverlay.cpp d468186 
>   player/lib/models/achievementsmodel.h 3df946e 
>   player/lib/models/achievementsmodel.cpp e1ebad0 
>   engine/game.cpp 9495909 
>   player/lib/models/gameviewitem.cpp 64dd46a 
> 
> Diff: http://git.reviewboard.kde.org/r/102245/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110816/343eabec/attachment-0001.html>